Closed
Bug 601863
Opened 14 years ago
Closed 14 years ago
Ensure all text strings are in dtd or properties file
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(blocking2.0 beta7+)
RESOLVED
FIXED
Firefox 4.0b7
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: raymondlee, Assigned: raymondlee)
Details
(Whiteboard: [strings][qa-])
Attachments
(1 file)
1.72 KB,
patch
|
dietrich
:
review+
iangilman
:
feedback+
|
Details | Diff | Splinter Review |
See summary
e.g. in _createUndoButton() in groupitems.js
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #480853 -
Flags: feedback?(ian)
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Created attachment 480853 [details] [diff] [review]
> v1
I've gone through panorama files and this is the only thing we need to update.
Assignee | ||
Updated•14 years ago
|
Attachment #480853 -
Attachment is patch: true
Attachment #480853 -
Attachment mime type: application/octet-stream → text/plain
Comment 3•14 years ago
|
||
Comment on attachment 480853 [details] [diff] [review]
v1
Good catch!
Do we need to make this beta7+ so it gets in before the string freeze?
Attachment #480853 -
Flags: review?(dietrich)
Attachment #480853 -
Flags: feedback?(ian)
Attachment #480853 -
Flags: feedback+
Updated•14 years ago
|
blocking2.0: --- → ?
Updated•14 years ago
|
Attachment #480853 -
Flags: review?(dietrich) → review+
Comment 4•14 years ago
|
||
Blocking b7+ on strings.
Updated•14 years ago
|
Whiteboard: [strings] → [strings][has patch, can land]
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [strings][has patch, can land] → [strings]
Target Milestone: --- → Firefox 4.0b7
Updated•14 years ago
|
Whiteboard: [strings] → [strings][qa-]
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•